Re: [PATCH v2 1/4] ASoC: cs35l45: Checks index of cs35l45_irqs[]

From: Richard Fitzgerald
Date: Thu Aug 31 2023 - 12:52:59 EST


On 31/8/23 15:56, Rivera-Matos, Ricardo wrote:
Hello Mark,

On Aug 30, 2023, at 3:59 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:

On Wed, Aug 30, 2023 at 02:55:33PM -0500, Vlad Karpovich wrote:
Checks the index computed by the virq offset before printing the
error condition in cs35l45_spk_safe_err() handler.

Signed-off-by: Ricardo Rivera-Matos <rriveram@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Vlad Karpovich <vkarpovi@xxxxxxxxxxxxxxxxxxxxx>

Who actually wrote this patch?

I am the original author, allow me to clarify how and why this is supposed to work.


I think Mark's comment is that the Signed-off-by chain doesn't match
the patch author. The s-o-b order implies that Ricardo wrote it and
Vlad is upstreaming it - but in that case this email should start with
a From: line to say that the author is Ricardo.