[PATCH 0/7] perf: strcmp_cpuid_str() expression fixups

From: James Clark
Date: Thu Aug 31 2023 - 11:16:53 EST


Set of fixes related to the comments here [1]. Mainly cleanups,
additional tests and refactoring since adding the new strcmp_cpuid_str()
metric expression.

I added the string replace function to the perf utils
rather than tools/lib/string.c because it didn't seem
easy to add tests for tools/lib.

[1]: https://lore.kernel.org/linux-arm-kernel/CAP-5=fVnUx0BnJC7X1rrm42OD7Bk=ZsHWNwAZMBYyB7yWhBfhQ@xxxxxxxxxxxxxx/

James Clark (7):
perf test: Check result of has_event(cycles) test
perf jevents: Remove unused keyword
perf util: Add a function for replacing characters in a string
perf test: Add a test for strcmp_cpuid_str() expression
perf pmu: Move pmu__find_core_pmu() to pmus.c
perf pmus: Simplify perf_pmus__find_core_pmu()
perf pmu: Remove unused function

tools/perf/arch/arm64/util/pmu.c | 20 ++++++-------
tools/perf/pmu-events/metric.py | 3 +-
tools/perf/tests/Build | 1 +
tools/perf/tests/builtin-test.c | 1 +
tools/perf/tests/expr.c | 33 ++++++++++++++++++----
tools/perf/tests/tests.h | 1 +
tools/perf/tests/util.c | 30 ++++++++++++++++++++
tools/perf/util/expr.c | 2 +-
tools/perf/util/pmu.c | 22 ---------------
tools/perf/util/pmu.h | 3 +-
tools/perf/util/pmus.c | 6 ++++
tools/perf/util/string.c | 48 ++++++++++++++++++++++++++++++++
tools/perf/util/string2.h | 1 +
13 files changed, 127 insertions(+), 44 deletions(-)
create mode 100644 tools/perf/tests/util.c

--
2.34.1