Re: [PATCH v2 1/5] dt-bindings: mfd: convert twl-family.tx to json-schema

From: Krzysztof Kozlowski
Date: Thu Aug 31 2023 - 02:27:09 EST


On 30/08/2023 20:20, Andreas Kemnade wrote:
> Convert the TWL[46]030 binding to DT schema format. To do it as a step by
> step work, do not include / handle nodes for subdevices yet, just convert
> things with minimal corrections. There are already some bindings for its
> subdevices in the tree.
>

...

> +properties:
> + compatible:
> + description:
> + TWL4030 for integrated power-management/audio CODEC device used in OMAP3
> + based boards
> + TWL6030/32 for integrated power-management used in OMAP4 based boards
> + enum:
> + - ti,twl4030
> + - ti,twl6030
> + - ti,twl6032
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 1
> +
> +additionalProperties: true

No, this must be false. example-schema and all device bindings require
this to be false. Having it true makes the schema basically no-op, so
why do you need it?


Best regards,
Krzysztof