Re: [PATCH 3/3] arm64: dts: qcom: ipq5018: enable the CPUFreq support

[Gokul Sriram P]

On 8/31/2023 1:12 AM, Dmitry Baryshkov wrote:
> On Wed, 30 Aug 2023 at 21:32, Gokul Sriram P <quic_gokulsri@xxxxxxxxxxx> wrote:
> > > > > > >     #include <dt-bindings/interrupt-controller/arm-gic.h>
> > > > > > >     #include <dt-bindings/clock/qcom,gcc-ipq5018.h>
> > > > > > >     #include <dt-bindings/reset/qcom,gcc-ipq5018.h>
> > > > > > > +#include <dt-bindings/clock/qcom,apss-ipq.h>
> > > > > > c is before r.
> >    Sure, will update.
> >
> > [...]
> > > > > > > +   cpu_opp_table: opp-table-cpu {
> > > > > > > +           compatible = "operating-points-v2";
> > > > > > > +           opp-shared;
> > > > > > > +
> > > > > > > +           opp-1008000000 {
> > > > > > > +                   opp-hz = /bits/ 64 <1008000000>;
> > > > > > > +                   opp-microvolt = <1100000>;
> > > > > > > +                   clock-latency-ns = <200000>;
> > > > > > And the rest of OPPs?
> > > > > Hi Krzysztof,
> > > > > IPQ5018 only supports running at 1.1GHz, but its running at 800MHz
> > > > > by default from the bootloader so there is only one OPP.
> > > > Isn't this contradictory? If it is running at 800 initially, then it
> > > > supports running at 800...
> > > I can only guess that it's not validated at 800MHz.
> > As per the h/w design team, there is negligible power or thermal benefit
> > by lowering to 800MHz clock.
> > Hence, 800MHz opp wasn't included here.
> Just my 2c. If 800 MHz is supported, it should be included. Even if
> just to prevent the kernel from throwing a warning about the CPU
> running at the unsupported frequency. Then one can use scheduler
> tunings to prevent the CPU from going to 800 MHz state.

sure, understood. Will add opp at 800MHz. Thanks.

Regards,
Gokul