Re: [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access

[Shravan Ramani]

>> Add secure read/write calls (arm_smccc_smc) to bluefield_edac.
>> The ACPI table entry decides whether SMC is need for accessing
>
> SMC? Self-Modifying Code?

SMC stands for Secure Monitor Call. ARM documentation can be found
here: https://developer.arm.com/documentation/den0028/latest/

SMC is needed by the driver to access certain HW blocks/registers which
can be accessed only from secure state. Whether a certain block requires
these secure calls or not is encoded in the ACPI table entry and passed
on to the driver.

>
>> +static int edac_readl(void __iomem *addr, uint32_t *result,
>
> No "edac_" previxes to driver-local functions. They belong to the EDAC
> subsystem.

Ack, will change the prefixes in v2.

Thanks,
Shravan