RE: [PATCH v3 1/3] dt-bindings: can: xilinx_can: Add ECC property 'xlnx,has-ecc'

From: Goud, Srinivas
Date: Wed Aug 30 2023 - 15:23:59 EST


Hi Krzysztof,

>-----Original Message-----
>From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>Sent: Wednesday, August 30, 2023 12:43 PM
>To: Goud, Srinivas <srinivas.goud@xxxxxxx>; Rob Herring <robh@xxxxxxxxxx>
>Cc: wg@xxxxxxxxxxxxxx; mkl@xxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx;
>edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx;
>krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
>p.zabel@xxxxxxxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx>; Simek, Michal
><michal.simek@xxxxxxx>; linux-can@xxxxxxxxxxxxxxx; linux-arm-
>kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
>appana.durga.rao@xxxxxxxxxx; naga.sureshkumar.relli@xxxxxxxxxx
>Subject: Re: [PATCH v3 1/3] dt-bindings: can: xilinx_can: Add ECC property
>'xlnx,has-ecc'
>
>On 30/08/2023 08:06, Goud, Srinivas wrote:
>>>> +
>>>> required:
>>>> - compatible
>>>> - reg
>>>> @@ -137,6 +141,7 @@ examples:
>>>> interrupts = <GIC_SPI 59 IRQ_TYPE_EDGE_RISING>;
>>>> tx-fifo-depth = <0x40>;
>>>> rx-fifo-depth = <0x40>;
>>>> + xlnx,has-ecc
>>>
>>> Obviously not tested.
>> Will fix it.
>>
>
>Fix it by fixing error or by testing? Can you do both?
Tested with v1 and missed in v2 due to copy paste, will test and send next version.

Thanks.
Srinivas