Re: [PATCH v4 0/4] Modify die() for MIPS

[Huacai Chen]

Hi, Thomas,

On Tue, Aug 29, 2023 at 11:44 PM Thomas Bogendoerfer
<tsbogend@xxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Aug 28, 2023 at 11:11:19AM +0200, Thomas Bogendoerfer wrote:
> > On Sat, Aug 19, 2023 at 04:36:19PM +0800, Tiezhu Yang wrote:
> > > v4:
> > >   -- Add BUG() at the end of nmi_exception_handler()
> > >   -- Return earlier in die() if notify_die() returns NOTIFY_STOP
> > >   -- Update the patch titles and commit messages
> > >
> > > v3:
> > >   -- Make each patch can be built without errors and warnings.
> > >
> > > v2:
> > >   -- Update the commit message to give more detailed info, split into
> > >      three individual patches, suggested by Maciej, thank you.
> > >
> > > Tiezhu Yang (4):
> > >   MIPS: Add BUG() at the end of nmi_exception_handler()
> > >   MIPS: Do not kill the task in die() if notify_die() returns
> > >     NOTIFY_STOP
> > >   MIPS: Return earlier in die() if notify_die() returns NOTIFY_STOP
> > >   MIPS: Add identifier names to arguments of die() declaration
> > >
> > >  arch/mips/include/asm/ptrace.h |  2 +-
> > >  arch/mips/kernel/traps.c       | 15 +++++++++------
> > >  2 files changed, 10 insertions(+), 7 deletions(-)
> >
> > series applied to mips-next.
>
> I've dropped the series again after feedback from Maciej, that this
> still needs more changes.
I feel a little surprised. This series has appeared for more than ten
days and received some R-b, and we haven't seen any objections from
Maciej. If there are really some bugs that need to be fixed, I think
the normal operation is making additional patches...

Huacai

>
> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]