Re: [PATCH v3] cpuidle, ACPI: Evaluate LPI arch_flags for broadcast timer

[kernel test robot]

Hi Oza,

kernel test robot noticed the following build warnings:

[auto build test WARNING on soc/for-next]
[also build test WARNING on v6.5]
[cannot apply to rafael-pm/linux-next arm64/for-next/core linus/master next-20230829]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Oza-Pawandeep/cpuidle-ACPI-Evaluate-LPI-arch_flags-for-broadcast-timer/20230830-041258
base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
patch link:    https://lore.kernel.org/r/20230829201101.3330337-1-quic_poza%40quicinc.com
patch subject: [PATCH v3] cpuidle, ACPI: Evaluate LPI arch_flags for broadcast timer
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230830/202308300720.JEfxnfQ5-lkp@xxxxxxxxx/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230830/202308300720.JEfxnfQ5-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308300720.JEfxnfQ5-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/acpi/processor_idle.c: In function 'acpi_processor_setup_lpi_states':
>> drivers/acpi/processor_idle.c:1220:61: warning: left-hand operand of comma expression has no effect [-Wunused-value]
    1220 |                 arch_update_idle_state_flags(lpi->arch_flags, &state->flags);
         |                                                             ^
>> drivers/acpi/processor_idle.c:1220:61: warning: statement with no effect [-Wunused-value]
    1220 |                 arch_update_idle_state_flags(lpi->arch_flags, &state->flags);
         |                                             ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~


vim +1220 drivers/acpi/processor_idle.c

  1201	
  1202	static int acpi_processor_setup_lpi_states(struct acpi_processor *pr)
  1203	{
  1204		int i;
  1205		struct acpi_lpi_state *lpi;
  1206		struct cpuidle_state *state;
  1207		struct cpuidle_driver *drv = &acpi_idle_driver;
  1208	
  1209		if (!pr->flags.has_lpi)
  1210			return -EOPNOTSUPP;
  1211	
  1212		for (i = 0; i < pr->power.count && i < CPUIDLE_STATE_MAX; i++) {
  1213			lpi = &pr->power.lpi_states[i];
  1214	
  1215			state = &drv->states[i];
  1216			snprintf(state->name, CPUIDLE_NAME_LEN, "LPI-%d", i);
  1217			strscpy(state->desc, lpi->desc, CPUIDLE_DESC_LEN);
  1218			state->exit_latency = lpi->wake_latency;
  1219			state->target_residency = lpi->min_residency;
> 1220			arch_update_idle_state_flags(lpi->arch_flags, &state->flags);
  1221			if (i != 0 && lpi->entry_method == ACPI_CSTATE_FFH)
  1222				state->flags |= CPUIDLE_FLAG_RCU_IDLE;
  1223			state->enter = acpi_idle_lpi_enter;
  1224			drv->safe_state_index = i;
  1225		}
  1226	
  1227		drv->state_count = i;
  1228	
  1229		return 0;
  1230	}
  1231	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki