Re: [PATCH v2 4/8] drm/ssd130x: Add support for DRM_FORMAT_R1

[Javier Martinez Canillas]

Javier Martinez Canillas <javierm@xxxxxxxxxx> writes:

> Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:
>
>> The native display format is monochrome light-on-dark (R1).
>> Hence add support for R1, so monochrome applications not only look
>> better, but also avoid the overhead of back-and-forth conversions
>> between R1 and XR24.
>>
>> Do not allocate the intermediate conversion buffer when it is not
>> needed, and reorder the two buffer allocations to streamline operation.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> ---
>> v2:
>>   - Rework on top op commit 8c3926367ac9df6c ("drm/ssd130x: Use
>>     shadow-buffer helpers when managing plane's state") in drm/drm-next.
>>     Hence I did not add Javier's tags given on v1.
>>   - Do not allocate intermediate buffer when not needed.
>> ---
>
> Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
>

Tested-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

> -- 
> Best regards,
>
> Javier Martinez Canillas
> Core Platforms
> Red Hat

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat