Re: [PATCH] vdpa/mlx5: Fix firmware error on creation of 1k VQs

From: kernel test robot
Date: Tue Aug 29 2023 - 15:03:49 EST


Hi Dragos,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.5 next-20230829]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Dragos-Tatulea/vdpa-mlx5-Fix-firmware-error-on-creation-of-1k-VQs/20230830-014600
base: linus/master
patch link: https://lore.kernel.org/r/20230829174219.928343-1-dtatulea%40nvidia.com
patch subject: [PATCH] vdpa/mlx5: Fix firmware error on creation of 1k VQs
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230830/202308300241.q7t7Ouf3-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230830/202308300241.q7t7Ouf3-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308300241.q7t7Ouf3-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/vdpa/mlx5/net/mlx5_vnet.c: In function 'read_umem_params':
>> drivers/vdpa/mlx5/net/mlx5_vnet.c:658:1: warning: the frame size of 4128 bytes is larger than 2048 bytes [-Wframe-larger-than=]
658 | }
| ^


vim +658 drivers/vdpa/mlx5/net/mlx5_vnet.c

627
628 static int read_umem_params(struct mlx5_vdpa_net *ndev)
629 {
630 u32 out[MLX5_ST_SZ_DW(query_hca_cap_out)] = {};
631 u32 in[MLX5_ST_SZ_DW(query_hca_cap_in)] = {};
632 u16 opmod = (MLX5_CAP_VDPA_EMULATION << 1) | (HCA_CAP_OPMOD_GET_CUR & 0x01);
633 struct mlx5_core_dev *mdev = ndev->mvdev.mdev;
634 void *caps;
635 int err;
636
637 MLX5_SET(query_hca_cap_in, in, opcode, MLX5_CMD_OP_QUERY_HCA_CAP);
638 MLX5_SET(query_hca_cap_in, in, op_mod, opmod);
639 err = mlx5_cmd_exec_inout(mdev, query_hca_cap, in, out);
640 if (err) {
641 mlx5_vdpa_warn(&ndev->mvdev,
642 "Failed reading vdpa umem capabilities with err %d\n", err);
643 return err;
644 }
645
646 caps = MLX5_ADDR_OF(query_hca_cap_out, out, capability);
647
648 ndev->umem_1_buffer_param_a = MLX5_GET(virtio_emulation_cap, caps, umem_1_buffer_param_a);
649 ndev->umem_1_buffer_param_b = MLX5_GET(virtio_emulation_cap, caps, umem_1_buffer_param_b);
650
651 ndev->umem_2_buffer_param_a = MLX5_GET(virtio_emulation_cap, caps, umem_2_buffer_param_a);
652 ndev->umem_2_buffer_param_b = MLX5_GET(virtio_emulation_cap, caps, umem_2_buffer_param_b);
653
654 ndev->umem_3_buffer_param_a = MLX5_GET(virtio_emulation_cap, caps, umem_3_buffer_param_a);
655 ndev->umem_3_buffer_param_b = MLX5_GET(virtio_emulation_cap, caps, umem_3_buffer_param_b);
656
657 return 0;
> 658 }
659

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki