Re: [PATCH 2/2] cpufreq: dt-platdev: Support building cpufreq platdev driver as module

From: Aurelien Jarno
Date: Tue Aug 29 2023 - 14:40:34 EST


Hi,

On 2023-05-24 15:34, Zhipeng Wang wrote:
> Make the cpufreq platdev driver as tristate so that it can be built
> as loadable module.
>
> Signed-off-by: Zhipeng Wang <zhipeng.wang_1@xxxxxxx>
> ---
> drivers/cpufreq/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 2c839bd2b051..dda3a78bfd5c 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -218,7 +218,7 @@ config CPUFREQ_DT
> If in doubt, say N.
>
> config CPUFREQ_DT_PLATDEV
> - bool
> + tristate "Generic DT based cpufreq platdev driver"
> help
> This adds a generic DT based cpufreq platdev driver for frequency
> management. This creates a 'cpufreq-dt' platform device, on the

It seems that this new module is missing support for autoloading,
causing issues with CPUFREQ_DT=m.

Before that change, CPUFREQ_DT_PLATDEV ended up selected as =y. Now,
CPUFREQ_DT_PLATDEV ends up selected as =m. As it is not autoloaded, it
means that cpufreq-dt is not working anymore unless manually running
"modprobe cpufreq-dt-platdev".

Could you therefore please add support for autoloading?

Thanks,
Aurelien

--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@xxxxxxxxxxx http://aurel32.net