Re: [PATCH v2 2/2] regulator: pv880x0: Drop CONFIG_OF ifdeffery

From: Andy Shevchenko
Date: Tue Aug 29 2023 - 11:18:47 EST


On Mon, Aug 28, 2023 at 06:24:17PM +0100, Biju Das wrote:
> Get rid of ugly CONFIG_OF ifdeffery by adding mod_devicetable.h include.

Commit message needs to be improved.
Inclusion of that header doesn't allow to do what you have done.
Dropping of_match_ptr() does. And you need to explain that leaving
OF table for non-OF system is fine and doesn't waste too much memory
anyway. Look for the existing changes like this in the kernel history
(`git log --no-merges --grep ...` at your service).

--
With Best Regards,
Andy Shevchenko