Re: [PATCH v2 2/2] mfd: palmas: Make similar OF and ID table

From: Andy Shevchenko
Date: Tue Aug 29 2023 - 10:47:12 EST


On Mon, Aug 28, 2023 at 04:31:44PM +0100, Biju Das wrote:
> Make similar OF and ID table to extend support for ID match using
> i2c_match_data(). Currently it works only for OF match tables as the
> driver_data is wrong for ID match.

...

> While at it, drop the inner leading commas for ID table.

Are you sure?

------------------v
> - { "palmas", },
> - { "twl6035", },
> - { "twl6037", },
> - { "tps65913", },
> + { "palmas", (kernel_ulong_t)&palmas_data },
> + { "twl6035", (kernel_ulong_t)&palmas_data },
> + { "twl6037", (kernel_ulong_t)&palmas_data },
> + { "tps65913", (kernel_ulong_t)&palmas_data },

--
With Best Regards,
Andy Shevchenko