Re: [PATCH v2 5/5] mm: Deprecate pasid field

From: Niklas Schnelle
Date: Tue Aug 29 2023 - 10:19:45 EST


On Sun, 2023-08-27 at 16:44 +0800, Tina Zhang wrote:
> Drop the pasid field, as all the information needed for sva domain
> management has been moved to the newly added iommu_mm field.

I think it should say "Drop" instead of "Deprecate" in the subject line
as well since this is field is completely removed.

>
> Signed-off-by: Tina Zhang <tina.zhang@xxxxxxxxx>
> ---
> include/linux/mm_types.h | 1 -
> mm/init-mm.c | 3 ---
> 2 files changed, 4 deletions(-)
>
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> index 3fd65b7537f0e..6cb5cc53c4803 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -808,7 +808,6 @@ struct mm_struct {
> struct work_struct async_put_work;
>
> #ifdef CONFIG_IOMMU_SVA
> - u32 pasid;
> struct iommu_mm_data *iommu_mm;
> #endif
> #ifdef CONFIG_KSM
> diff --git a/mm/init-mm.c b/mm/init-mm.c
> index efa97b57acfd8..69719291463ed 100644
> --- a/mm/init-mm.c
> +++ b/mm/init-mm.c
> @@ -42,9 +42,6 @@ struct mm_struct init_mm = {
> #endif
> .user_ns = &init_user_ns,
> .cpu_bitmap = CPU_BITS_NONE,
> -#ifdef CONFIG_IOMMU_SVA
> - .pasid = IOMMU_PASID_INVALID,
> -#endif
> INIT_MM_CONTEXT(init_mm)
> };
>