Re: [PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps

From: Andy Shevchenko
Date: Tue Aug 29 2023 - 09:26:07 EST


On Mon, Aug 28, 2023 at 09:06:09PM +0300, Sergey Ryazanov wrote:
> On 28.08.2023 16:19, Andy Shevchenko wrote:
> > Use bitmap_zalloc() and bitmap_free() instead of hand-writing them.
> > It is less verbose and it improves the type checking and semantic.
> >
> > While at it, add missing header inclusion (should be bitops.h,
> > but with the above change it becomes bitmap.h).
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Make sense. Thank you.
>
> BTW, any plans to update __dev_alloc_name(), which was used as reference, in
> the same way?

Ah, will look at it, thanks for the pointer.

> Reviewed-by: Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx>

And thank you for the review!

--
With Best Regards,
Andy Shevchenko