Re: [PATCH] mmc: atmel-mci: Remove preprocessor directive

From: Linus Walleij
Date: Tue Aug 29 2023 - 03:19:48 EST


On Mon, Aug 28, 2023 at 12:04 PM Balamanikandan Gunasundar
<balamanikandan.gunasundar@xxxxxxxxxxxxx> wrote:

> Remove the preprocessor directive IS_ENABLED(CONFIG_MMC_ATMELMCI) while
> checking if the device is compatible with atmel,hsmci. Instead handle it in
> the if() condition. The compiler optimizes out the entire if() clause if
> the first expression in the if() clause is constant false.
>
> Signed-off-by: Balamanikandan Gunasundar <balamanikandan.gunasundar@xxxxxxxxxxxxx>
> Suggested-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks for tidying this up Balamanikandan!

Yours,
Linus Walleij