Re: [PATCH] cpufreq: Fix inconsistency in error messages of cpufreq_resume/suspend()

From: Viresh Kumar
Date: Tue Aug 29 2023 - 02:02:10 EST


On 28-08-23, 20:31, Liao, Chang wrote:
> What about printing message like this below when cpufreq_start_governor() fails.
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 50bbc969ffe5..b78b509429a6 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1943,16 +1943,16 @@ void cpufreq_resume(void)
>
> if (ret)
> - pr_err("%s: Failed to start governor for policy: %p\n",
> - __func__, policy);
> + pr_err("%s: Failed to start governor for policy%u\n",

s/policy/CPU%u's policy/ ?

> + __func__, policy->cpu);

Sounds good.

--
viresh