Re: [PATCH v3 7/8] bitmap: drop _reg_op() function

From: Yury Norov
Date: Mon Aug 28 2023 - 21:54:08 EST


On Thu, Aug 17, 2023 at 12:47:56PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 15, 2023 at 04:36:27PM -0700, Yury Norov wrote:
> > Now that all _reg_op() users are switched to alternative functions,
> > _reg_op() machinery is not needed anymore.
>
> ...
>
> > - * Can set, verify and/or release a region of bits in a bitmap,
> > - * depending on which combination of REG_OP_* flag bits is set.
> > - *
> > - * A region of a bitmap is a sequence of bits in the bitmap, of
> > - * some size '1 << order' (a power of two), aligned to that same
> > - * '1 << order' power of two.
>
> Just wondering if we have some equivalent to the above doc in the
> existing kernel doc of users of this.

This comment is not fully correct because the code doesn't enforce
alignment of the region. Let's drop this part just as well.