Re: [PATCH bpf-next v8] selftests/bpf: trace_helpers.c: optimize kallsyms cache

From: Rong Tao
Date: Mon Aug 28 2023 - 20:49:36 EST


> > Hi, jirka. Thanks for your reply.
> >
> > > > @@ -164,13 +165,14 @@ int main(int argc, char **argv)
> > > > }
> > > >
> > > > /* initialize kernel symbol translation */
> > > > - if (load_kallsyms()) {
> > > > + ksyms = load_kallsyms();
> > >
> > > if we keep the load_kallsyms/ksym_search/ksym_get_addr functions as described
> > > in [1] the samples/bpf would stay untouched apart from the Makefile change
> >
> > Maybe we should make this modification, wouldn't it be better? After all,
> > not modifying the source code of samples/bpf is not really a reason not to
> > make modifications to load_kallsyms(), what do you think?
>
> I think we want separate selftest and samples changes and I don't see
> other way to do that

Thanks, jirka, I didn't notice this in the previous discussion, sorry.
Let me try to solve this problem.

Rong Tao