Re: [PATCH 1/2] ARM: dts: qcom: sdx65: correct PCIe EP phy-names

From: Krzysztof Kozlowski
Date: Mon Aug 28 2023 - 06:30:43 EST


On 28/08/2023 11:53, Konrad Dybcio wrote:
> On 27.08.2023 13:45, Krzysztof Kozlowski wrote:
>> Qualcomm PCIe endpoint bindings expect phy-names to be "pciephy":
>>
>> arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dtb: pcie-ep@1c00000: phy-names:0: 'pciephy' was expected
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
> drivers/pci/controller/dwc/pcie-qcom-ep.c
> 549: pcie_ep->phy = devm_phy_optional_get(dev, "pciephy");
>
> welp looks like this never worked..

And if only it could have been spotted with some automated tooling,
before posting to LKML...

>
>
> Fixes: 9c0bb38414a4 ("ARM: dts: qcom: sdx65: Add support for PCIe EP")
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>


Thanks

Best regards,
Krzysztof