Re: [PATCH v3] usb: typec: qcom: check regulator enable status before disabling it

From: Konrad Dybcio
Date: Mon Aug 28 2023 - 05:51:19 EST


On 28.08.2023 07:16, Hui Liu via B4 Relay wrote:
> From: Hui Liu <quic_huliu@xxxxxxxxxxx>
>
> Check regulator enable status before disabling it to avoid
> unbalanced regulator disable warnings.
>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Acked-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Signed-off-by: Hui Liu <quic_huliu@xxxxxxxxxxx>
> ---
> Changes in v3:
> - Take Bryan's proposal to remove enable/disable operation in pdphy
> enable and pdphy disable function, then enable regulator in pdphy start
> function and disable it in pdphy stop function.
The commit message makes no sense now, it should have been updated
to reflect what you're doing after the logic had changed.

Konrad