Re: [PATCH 3/6] arm64: dts: freescale: add initial device tree for TQMLS1043A/TQMLS1046A

[Krzysztof Kozlowski]

On 23/08/2023 14:09, Gregor Herburger wrote:
> This adds support for the TQMLS1043A and TQMLS1046A SOM and the
> MBLS10xxA baseboard. TQMLS1043A and TQMLS1046A share a common layout
> and can be used on the MBLS10xxA.
> 
> Signed-off-by: Gregor Herburger <gregor.herburger@xxxxxxxxxxxxxxx>

...

> +&i2c3 {
> +	status = "okay";
> +
> +	i2c-mux@70 {
> +		compatible = "nxp,pca9544";
> +		reg = <0x70>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		i2c@0 {
> +			reg = <0x0>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			gpioexp1: pca9555@20 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation


> +				compatible = "nxp,pca9555";
> +				reg = <0x20>;
> +				vcc-supply = <&reg_3v3>;
> +				gpio-controller;
> +				#gpio-cells = <2>;
> +			};

...

> +
> +&esdhc {
> +	/* eSDHC or eMMC: set by bootloader */
> +	non-removable;
> +	disable-wp;
> +	mmc-hs200-1_8v;
> +	sd-uhs-sdr104;
> +	sd-uhs-sdr50;
> +	sd-uhs-sdr25;
> +	sd-uhs-sdr12;
> +};
> +

Stray blank line.

Best regards,
Krzysztof