Re: [PATCH V2 1/3] ASoC: dt-bindings: fsl_easrc: Add support for imx8mp-easrc

From: Conor Dooley
Date: Sun Aug 27 2023 - 08:20:27 EST


On Sat, Aug 26, 2023 at 09:31:53PM -0500, Adam Ford wrote:
> The i.MX8MP appears to have the same easrc support as the Nano, so
> add imx8mp as an option with a fallback to imx8mn.
>
> Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
> ---
> V2: Fixed errors:
> ['fsl,imx8mn-easrc'] is too short
> 'fsl,imx8mn-easrc' is not one of ['fsl,imx8mp-easrc']
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> index bdde68a1059c..a680d7aff237 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> @@ -14,7 +14,13 @@ properties:
> pattern: "^easrc@.*"
>
> compatible:
> - const: fsl,imx8mn-easrc
> + oneOf:
> + - enum:
> + - fsl,imx8mn-easrc

This one should probably stay const, no?
Either way,
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

> + - items:
> + - enum:
> + - fsl,imx8mp-easrc
> + - const: fsl,imx8mn-easrc
>
> reg:
> maxItems: 1
> --
> 2.39.2
>

Attachment: signature.asc
Description: PGP signature