Re: [PATCH v3 07/15] media: qcom: camss: Capture VFE CSID dependency in a helper function

From: Bryan O'Donoghue
Date: Sat Aug 26 2023 - 08:17:47 EST


On 26/08/2023 13:13, Konrad Dybcio wrote:
On 26.08.2023 14:12, Bryan O'Donoghue wrote:
On 26/08/2023 13:04, Konrad Dybcio wrote:
  From sdm845 onwards we need to ensure the VFE is powered on prior to
switching on the CSID.
And what's the symptom if we fail to ensure this? How can someone
adding support for another platform tell whether the match-list
should be expanded?
That person has to understand the dependency.
If we need this workaround, there surely must be something that doesn't
work without it, a measurable symptom. What is it?

The CSID lives inside of the VFE therefore the VFE must be power prior to the CSID.

The symptom will be .. the CSID doesn't come out of reset.
Good, that's what I needed to know.

Now we can rename that function to something like camss_csid_inside_vfe()
to make it more meaningful

If you feel there is a meaningful distinction between "csid_depends_vfe()" and "camss_csid_inside_vfe()"

I'm happy to humour you.

---
bod