Re: [PATCH v2 00/13] fixes and cleanups to ext4 resize

[Kemeng Shi]

Please ignore this version and sorry for the noise...

on 8/27/2023 1:37 AM, Kemeng Shi wrote:
> This series contains some random cleanups and a few fixes to correct gdb
> backup copy, fix buffer_head leak and so on. More details can be found
> in respective log messages.
> I run kvm-xfstest with config "ext4/all" and "-g auto" together with
> mballoc patchset I sent before.
> 
> v1->v2:
> -Prioritize returning error in "err" in patch 3
> -Rewrite patch 11
> -Improve description and add comment to sbi->s_group_desc in patch 12
> -Collect RVB from Ted for rest patches
> 
> -------------------- Summary report
> KERNEL:    kernel 6.4.0-rc5-xfstests-g90158dd3c06b #23 SMP PREEMPT_DYNAMIC
> Wed Jun 28 17:19:32 CST 2023 x86_64
> CPUS:      2
> MEM:       1975.36
> 
> ext4/4k: 531 tests, 31 skipped, 3421 seconds
> ext4/1k: 527 tests, 33 skipped, 4638 seconds
> ext4/ext3: 523 tests, 119 skipped, 3289 seconds
> ext4/encrypt: 509 tests, 3 failures, 138 skipped, 2163 seconds
>   Failures: generic/681 generic/682 generic/691
> ext4/nojournal: 526 tests, 5 failures, 98 skipped, 3469 seconds
>   Failures: ext4/301 ext4/304 generic/455 generic/459 generic/581
> ext4/ext3conv: 528 tests, 31 skipped, 3877 seconds
> ext4/adv: 528 tests, 4 failures, 38 skipped, 4170 seconds
>   Failures: generic/475 generic/477
>   Flaky: generic/455: 80% (4/5)   generic/482: 80% (4/5)
> ext4/dioread_nolock: 529 tests, 31 skipped, 3825 seconds
> ext4/data_journal: 527 tests, 3 failures, 99 skipped, 3307 seconds
>   Failures: generic/455 generic/484
>   Flaky: generic/068: 40% (2/5)
> ext4/bigalloc_4k: 503 tests, 35 skipped, 3286 seconds
> ext4/bigalloc_1k: 503 tests, 1 failures, 43 skipped, 4421 seconds
>   Failures: shared/298
> Totals: 5798 tests, 696 skipped, 75 failures, 0 errors, 39645s
> 
> FSTESTVER: blktests 676d42c (Thu, 2 Mar 2023 15:25:44 +0900)
> FSTESTVER: e2fsprogs archive/debian/1.47.0-1 (Mon, 6 Feb 2023 22:36:16 -0500)
> FSTESTVER: fio  fio-3.31 (Tue, 9 Aug 2022 14:41:25 -0600)
> FSTESTVER: fsverity v1.5-6-g5d6f7c4 (Mon, 30 Jan 2023 23:22:45 -0800)
> FSTESTVER: ima-evm-utils v1.3.2 (Wed, 28 Oct 2020 13:18:08 -0400)
> FSTESTVER: nvme-cli v1.16 (Thu, 11 Nov 2021 13:09:06 -0800)
> FSTESTVER: quota  v4.05-53-gd90b7d5 (Tue, 6 Dec 2022 12:59:03 +0100)
> FSTESTVER: util-linux v2.38.1 (Thu, 4 Aug 2022 11:06:21 +0200)
> FSTESTVER: xfsprogs v6.1.1 (Fri, 13 Jan 2023 19:06:37 +0100)
> FSTESTVER: xfstests v2023.02.26-8-g821ef488 (Thu, 2 Mar 2023 10:23:51 -0500)
> FSTESTVER: xfstests-bld 35650073 (Mon, 6 Mar 2023 20:48:08 -0500)
> FSTESTVER: zz_build-distro bullseye
> FSTESTCFG: ext4/all
> FSTESTSET: -g auto
> FSTESTOPT: aex
> 
> There more failures compared with "good" report in reply from Ted [1] as
> following:
> ext4/nojournal: generic/459 generic/581
> ext4/adv: Flaky: generic/455: 80% (4/5)   generic/482: 80% (4/5)
> ext4/data_journal: Flaky: generic/068: 40% (2/5)
> It seems still a "good" test run according to rules listed in [1].
> Please let me know if more tests to run. Thanks!
> 
> [1] https://lore.kernel.org/linux-ext4/db478a24-39f5-3cef-8814-89406ce4d2ca@xxxxxxxxxx/T/#ma9de3f355f0300291d32fe1f0b32c5660c9bd191
> 
> Kemeng Shi (13):
>   ext4: correct offset of gdb backup in non meta_bg group to
>     update_backups
>   ext4: add missed brelse in update_backups
>   ext4: correct return value of ext4_convert_meta_bg
>   ext4: remove gdb backup copy for meta bg in
>     setup_new_flex_group_blocks
>   ext4: fix typo in setup_new_flex_group_blocks
>   ext4: remove redundant check of count
>   ext4: remove commented code in reserve_backup_gdb
>   ext4: calculate free_clusters_count in cluster unit in
>     verify_group_input
>   ext4: remove EXT4FS_DEBUG defination in resize.c
>   ext4: use saved local variable sbi instead of EXT4_SB(sb)
>   ext4: simplify the gdbblock calculation in add_new_gdb_meta_bg
>   ext4: remove unnecessary check to avoid repeat update_backups for the
>     same gdb
>   ext4: remove unnecessary initialization of count2 in
>     set_flexbg_block_bitmap
> 
>  fs/ext4/ext4.h   |  1 +
>  fs/ext4/resize.c | 88 ++++++++++++++++++++----------------------------
>  2 files changed, 38 insertions(+), 51 deletions(-)
>