Re: [PATCH] i2c: pxa: fix clang -Wvoid-pointer-to-enum-cast warning
From: Wolfram Sang
Date: Fri Aug 25 2023 - 18:18:17 EST
> Note: I think something like this may be more readable:
> | *i2c_types = (enum pxa_i2c_types)(uintptr_t)of_id->data;
>
> Thoughts on this approach against the one present in this patch?
On the one hand, I think this is more explicit and, thus, more readable.
On the other hand, we still have the loss of precision, between the
first and the second cast. Which gives it a bit of a "let's hide it
somewhat so the compiler will be happy" feeling?
Attachment:
signature.asc
Description: PGP signature