Re: [PATCH v2 1/1] scripts: Add add-maintainer.py

From: Guru Das Srinagesh
Date: Fri Aug 25 2023 - 13:01:41 EST


On Aug 25 2023 13:44, Nicolas Schier wrote:
> On Thu 24 Aug 2023 14:44:36 GMT, Guru Das Srinagesh wrote:
> > > While testing, I thought that adding addresses without filtering-out duplicates
> > > was odd; but as git-send-email does the unique filtering, it doesn't matter.
> >
> > Since I'm using `set()` in this script, the uniqueness is guaranteed here as
> > well - there won't be any duplicates.
>
> I thought about patch files that already have 'To/Cc' headers (e.g.
> 'git format-patch --to=... --cc=...' or by running add-maintainer.py
> multiple times for updating the lists of recipients. The result is a
> patch file with possible duplicated lines; but as written: it does
> matter, effectively.

Sorry, did you mean "does" or "does *not*"?

I'll make sure to test v3 of this script out on patches that have To/Cc already
included and also run it multiple times on the same patch (effectively the same
thing).

Thank you.

Guru Das.