Re: [PATCH] arm: dts: bcm2711: Describe Ethernet LEDs

[Florian Fainelli]

On 8/22/23 06:18, Andrew Lunn wrote:
> On Mon, Aug 21, 2023 at 12:27:11PM -0700, Florian Fainelli wrote:
> > Describe the Ethernet LEDs for the Raspberry Pi 4 model B board as well
> > as the Raspberry Pi 4 CM board.
> >
> > Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 18 ++++++++++++++++++
> >   .../arm/boot/dts/broadcom/bcm2711-rpi-cm4.dtsi | 18 ++++++++++++++++++
> >   2 files changed, 36 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> > index d5f8823230db..41db78cb0836 100644
> > --- a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> > +++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> > @@ -5,6 +5,7 @@
> >   #include "bcm283x-rpi-led-deprecated.dtsi"
> >   #include "bcm283x-rpi-usb-peripheral.dtsi"
> >   #include "bcm283x-rpi-wifi-bt.dtsi"
> > +#include <dt-bindings/leds/common.h>
> >   
> >   / {
> >   	compatible = "raspberrypi,4-model-b", "brcm,bcm2711";
> > @@ -197,6 +198,23 @@ &genet_mdio {
> >   	phy1: ethernet-phy@1 {
> >   		/* No PHY interrupt */
> >   		reg = <0x1>;
> > +
> > +		leds {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +
> > +			leds@0 {
> > +				color = <LED_COLOR_ID_GREEN>;
> > +				default-state = "keep";
> > +				reg = <0>;
> > +			};
> > +
> > +			leds@1 {
> > +				color = <LED_COLOR_ID_AMBER>;
> > +				default-state = "keep";
> > +				reg = <1>;
>
> Hi Florian
>
> When we submitted leds in DT nodes as part of the merge, Rob wanted
> the function property set. armada-370-rd.dts has:
>
> function = LED_FUNCTION_WAN
>
> because that port would typically be connected to your cable router
> etc. But LED_FUNCTION_LAN also exists. This property can influence
> naming so adding it later could be an ABI violation.

So in this case, the amber LED indicates the link activity, and the 
green LED indicates the link status. AFAICT we still do not have 
function names defined for those, the closest I can think is to do:

function = LED_FUNCTION_ACTIVITY for the amber LED

and for the green LED:

function = (LED_FUNCTION_RX | LED_FUNCTION_TX)

is that acceptable?
--
Florian

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature