Re: [PATCH v2] brcm80211: brcmsmac: phy: Remove unreachable code

From: Jonas Gorski
Date: Fri Aug 25 2023 - 04:35:08 EST


Hi,

On Mon, 14 Aug 2023 at 11:36, Artem Chernyshev
<artem.chernyshev@xxxxxxxxxxx> wrote:
>
> wlc_phy_txpwr_srom_read_nphy() in wlc_phy_attach_nphy() can not
> return false, so it's impossible to get true value in this
> if-statement. Also change those functions return types to void
> since no one using it.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Artem Chernyshev <artem.chernyshev@xxxxxxxxxxx>

Since Broadcom seems to be on vacation or so, have a

Reviewed-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>

to have at least some feedback.

Regards,
Jonas