Re: [PATCH 13/22] x86/srso: Fix vulnerability reporting for missing microcode

[Borislav Petkov]

On Sun, Aug 20, 2023 at 06:19:10PM -0700, Josh Poimboeuf wrote:
> + * 'Vulnerable: Safe RET, no microcode':
> +
> +   The "Safe Ret" mitigation (see below) has been applied to protect the

s/Ret/RET/

> @@ -2456,7 +2463,10 @@ static void __init srso_select_mitigation(void)
>  				setup_force_cpu_cap(X86_FEATURE_SRSO);
>  				x86_return_thunk = srso_return_thunk;
>  			}
> -			srso_mitigation = SRSO_MITIGATION_SAFE_RET;
> +			if (has_microcode)
> +				srso_mitigation = SRSO_MITIGATION_SAFE_RET;
> +			else
> +				srso_mitigation = SRSO_MITIGATION_SAFE_RET_UCODE_NEEDED;
>  		} else {
>  			pr_err("WARNING: kernel not compiled with CPU_SRSO.\n");
>  		}

You missed one "no microcode" here at out_print:

[    0.553950] Speculative Return Stack Overflow: Vulnerable: Safe RET, no microcode, no microcode

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette