Re: [RFC PATCH 0/4] treewide: Use clocksource id for get_device_system_crosststamp()

From: John Stultz
Date: Fri Aug 25 2023 - 00:19:46 EST


On Thu, Aug 17, 2023 at 6:13 PM Peter Hilber
<peter.hilber@xxxxxxxxxxxxxxx> wrote:
>
> This patch series changes struct system_counterval_t to identify the
> clocksource through enum clocksource_ids, rather than through struct
> clocksource *. The net effect of the patch series is that
> get_device_system_crosststamp() callers can supply clocksource ids instead
> of clocksource pointers, which can be problematic to get hold of.

Hey Peter,
Thanks for sending this out. I'm a little curious though, can you
expand a bit on how clocksource pointers can be problematic to get a
hold of? What exactly is the problem that is motivating this change?

I just worry that switching to an enumeration solution might be
eventually exposing more than we would like to userland.

thanks
-john