[paulmck-rcu:dev.2023.08.22a 61/69] kernel/locking/qspinlock.c:709:102: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int'
From: kernel test robot
Date: Thu Aug 24 2023 - 21:49:43 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2023.08.22a
head: 354957ec11dc80eac68c4b1e10c237d69adc1833
commit: bdd8d60bd4047aa4a7dc207789dc4ad0dfd5f07e [61/69] EXP qspinlock: Dump lock state, add call from locktorture
config: mips-randconfig-r023-20230825 (https://download.01.org/0day-ci/archive/20230825/202308250917.NOqF6Mad-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230825/202308250917.NOqF6Mad-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308250917.NOqF6Mad-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> kernel/locking/qspinlock.c:709:102: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Wformat]
709 | pr_alert("%s: _Q_TAIL_CPU_OFFSET=%d _Q_TAIL_IDX_MASK=%d _Q_TAIL_IDX_OFFSET=%d _Q_LOCKED_VAL=%d _Q_TAIL_OFFSET=%d sizeof(->tail)=%lu\n",
| ~~~
| %u
710 | __func__, _Q_TAIL_CPU_OFFSET, _Q_TAIL_IDX_MASK, _Q_TAIL_IDX_OFFSET, _Q_LOCKED_VAL, _Q_TAIL_OFFSET, sizeof(qval.tail));
| ^~~~~~~~~~~~~~~~~
include/linux/printk.h:478:35: note: expanded from macro 'pr_alert'
478 | printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/printk.h:455:60: note: expanded from macro 'printk'
455 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/printk.h:427:19: note: expanded from macro 'printk_index_wrap'
427 | _p_func(_fmt, ##__VA_ARGS__); \
| ~~~~ ^~~~~~~~~~~
>> kernel/locking/qspinlock.c:691:6: warning: no previous prototype for function 'spinlock_dump' [-Wmissing-prototypes]
691 | void spinlock_dump(spinlock_t *sp, bool full)
| ^
kernel/locking/qspinlock.c:691:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
691 | void spinlock_dump(spinlock_t *sp, bool full)
| ^
| static
2 warnings generated.
vim +709 kernel/locking/qspinlock.c
690
> 691 void spinlock_dump(spinlock_t *sp, bool full)
692 {
693 int cpu;
694 int i = 0;
695 int idx;
696 struct mcs_spinlock *msp;
697 struct qspinlock qval = sp->rlock.raw_lock;
698
699 cpu = tail_to_cpu(qval.tail);
700 idx = tail_to_idx(qval.tail);
701 pr_alert("%s: %ps %#x (%c%c%c%c %#x: %d[%d]\n",
702 __func__, sp, (unsigned int)atomic_read(&qval.val),
703 ".L"[!!qval.locked],
704 ".P"[!!qval.pending],
705 ".Q"[cpu >= 0 && idx >= 0],
706 ".F"[!!full],
707 (unsigned int)qval.tail, cpu, idx);
708 pr_alert("%s: _Q_TAIL_CPU_OFFSET=%d _Q_TAIL_IDX_MASK=%d _Q_TAIL_IDX_OFFSET=%d _Q_LOCKED_VAL=%d _Q_TAIL_OFFSET=%d sizeof(->tail)=%lu\n",
> 709 __func__, _Q_TAIL_CPU_OFFSET, _Q_TAIL_IDX_MASK, _Q_TAIL_IDX_OFFSET, _Q_LOCKED_VAL, _Q_TAIL_OFFSET, sizeof(qval.tail));
710 if (!full)
711 return;
712 while (i++ < nr_cpu_ids && (msp = next_to_prev(msp, &cpu, &idx))) {
713 pr_alert("%s: Q%d CPU %d[%d] %c%d\n", __func__, i, cpu, idx,
714 ".L"[!!msp->locked], msp->count);
715 }
716 if (i >= nr_cpu_ids && cpu >= 0 && idx >= 0)
717 pr_alert("%s: Queue output truncated.\n", __func__);
718 else
719 pr_alert("%s: End of queue.\n", __func__);
720 }
721 EXPORT_SYMBOL(spinlock_dump);
722
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki