[PATCH] x86/shstk: Change order of __user in type

From: Rick Edgecombe
Date: Thu Aug 24 2023 - 21:47:38 EST


0day reports a sparse warning:
arch/x86/kernel/shstk.c:295:55: sparse: sparse: cast removes address space
'__user' of expression

The __user is in the wrong spot. Move it to right spot and make sparse
happy.

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202308222312.Jt4Tog5T-lkp@xxxxxxxxx/
Signed-off-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>
---
arch/x86/kernel/shstk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/shstk.c b/arch/x86/kernel/shstk.c
index cd10d074a444..fd689921a1db 100644
--- a/arch/x86/kernel/shstk.c
+++ b/arch/x86/kernel/shstk.c
@@ -275,7 +275,7 @@ static int shstk_push_sigframe(unsigned long *ssp)
return -EINVAL;

*ssp -= SS_FRAME_SIZE;
- if (put_shstk_data((void *__user)*ssp, target_ssp))
+ if (put_shstk_data((void __user *)*ssp, target_ssp))
return -EFAULT;

return 0;
--
2.34.1