Re: [PATCH v1 1/1] amba: bus: balance firmware node reference counting

From: kernel test robot
Date: Thu Aug 24 2023 - 16:00:26 EST


Hi Andy,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20230824]
[cannot apply to rafael-pm/linux-next robh/for-next soc/for-next linus/master v6.5-rc7 v6.5-rc6 v6.5-rc5 v6.5-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/amba-bus-balance-firmware-node-reference-counting/20230825-003007
base: next-20230824
patch link: https://lore.kernel.org/r/20230824162654.2890992-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] amba: bus: balance firmware node reference counting
config: arm-defconfig (https://download.01.org/0day-ci/archive/20230825/202308250317.taQ9kshJ-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230825/202308250317.taQ9kshJ-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308250317.taQ9kshJ-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

drivers/amba/bus.c: In function 'amba_device_release':
>> drivers/amba/bus.c:532:46: error: expected ')' before ';' token
532 | fwnode_handle_put(dev_fwnode(&d->dev);
| ~ ^
>> drivers/amba/bus.c:536:18: error: expected ';' before '}' token
536 | kfree(d);
| ^
| ;
537 | }
| ~


vim +532 drivers/amba/bus.c

527
528 static void amba_device_release(struct device *dev)
529 {
530 struct amba_device *d = to_amba_device(dev);
531
> 532 fwnode_handle_put(dev_fwnode(&d->dev);
533 if (d->res.parent)
534 release_resource(&d->res);
535 mutex_destroy(&d->periphid_lock);
> 536 kfree(d);
537 }
538

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki