Re: [PATCH v3] dt-bindings: irqchip: convert st,stih407-irq-syscfg to DT schema

From: Krzysztof Kozlowski
Date: Thu Aug 24 2023 - 12:42:51 EST


On 24/08/2023 18:32, Raphaël Gallais-Pou wrote:
>>> + st,invert-ext:
>>> + description: External IRQs can be inverted at will. This property inverts
>>> + these IRQs using bitwise logic.
>>
>> So this is a mask?
>
> Of course, I did not had clarity given the hour I sent this, but it is
> indeed a bitmask.
>>
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> + enum: [ 1, 2, 4]
>>
>> If so, then this is wrong if you want to set more than 1 bit.
> So knowing this is a mask, it can take any integer between 1 and 4 in
> our case.

No, 1 + 4 = 5. *more than 1 bit*

Best regards,
Krzysztof