Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file

From: Shenwei Wang
Date: Thu Aug 24 2023 - 12:35:54 EST




> -----Original Message-----
> From: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Sent: Thursday, August 24, 2023 4:27 AM
> To: Shenwei Wang <shenwei.wang@xxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>;
> imx@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> dl-linux-imx <linux-imx@xxxxxxx>
> Subject: [EXT] Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
>
>
> On Fri, 18 Aug 2023 at 17:35, Shenwei Wang <shenwei.wang@xxxxxxx> wrote:
> >
> > Documenting the regulator power domain properties and usage examples.
>
> As Rob and Krzysztof already pointed out, I agree that this binding looks a bit
> questionable.
>
> Rather than adding a new DT binding, why can't we just use the existing way of
> describing a platform specific power-domain provider?

Can you please provide more details on how you thought we should implement this
feature using the existing way? Very appreciate if you could provide a simple example.

> This still looks platform specific to me.

What does platform specific exactly mean here? I want to make sure I understand
what you were referring to.

Thanks,
Shenwei

>
> Kind regards
> Uffe
>
> >
> > Signed-off-by: Shenwei Wang <shenwei.wang@xxxxxxx>
> > ---
> > .../bindings/power/regulator-pd.yaml | 71 +++++++++++++++++++
> > 1 file changed, 71 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/power/regulator-pd.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/power/regulator-pd.yaml
> > b/Documentation/devicetree/bindings/power/regulator-pd.yaml
> > new file mode 100644
> > index 000000000000..181d2fa83f8a