Re: [PATCH v8 7/7] iio: accel: Add support for Kionix/ROHM KX132-1211 accelerometer

From: Andy Shevchenko
Date: Thu Aug 24 2023 - 09:41:11 EST


On Thu, Aug 24, 2023 at 03:51:18PM +0300, Matti Vaittinen wrote:
> On 8/24/23 15:02, Andy Shevchenko wrote:
> > On Wed, Aug 23, 2023 at 11:16:41PM +0200, Mehdi Djait wrote:

...

> > > + .yes_ranges = &kx132_volatile_ranges[0],
> >
> >
> > This should be the same as
> >
> > .yes_ranges = kx132_volatile_ranges,
> >
>
> The driver uses &kx132_volatile_ranges[0] in a few places (for kx022a) so I
> believe this is okay. Well, I know I am biased as I do personally find
> &kx132_volatile_ranges[0] clearer. Here we point to the first element in an
> array - and yes, it may be I am minority here - but at least I wouldn't ask
> for changing this.

It's a minor thingy, can be ignored.

--
With Best Regards,
Andy Shevchenko