Re: [PATCH v2 6/6] drm/drm-file: Allow size unit selection in drm_show_memory_stats
From: kernel test robot
Date: Thu Aug 24 2023 - 02:51:00 EST
Hi Adrián,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v6.5-rc7 next-20230823]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Adri-n-Larumbe/drm-panfrost-Add-cycle-count-GPU-register-definitions/20230824-093848
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20230824013604.466224-7-adrian.larumbe%40collabora.com
patch subject: [PATCH v2 6/6] drm/drm-file: Allow size unit selection in drm_show_memory_stats
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230824/202308241401.Hr6gvevs-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230824/202308241401.Hr6gvevs-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308241401.Hr6gvevs-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/drm_file.c:905: warning: Function parameter or member 'unit' not described in 'drm_print_memory_stats'
vim +905 drivers/gpu/drm/drm_file.c
686b21b5f6ca2f Rob Clark 2023-05-24 891
686b21b5f6ca2f Rob Clark 2023-05-24 892 /**
686b21b5f6ca2f Rob Clark 2023-05-24 893 * drm_print_memory_stats - A helper to print memory stats
686b21b5f6ca2f Rob Clark 2023-05-24 894 * @p: The printer to print output to
686b21b5f6ca2f Rob Clark 2023-05-24 895 * @stats: The collected memory stats
686b21b5f6ca2f Rob Clark 2023-05-24 896 * @supported_status: Bitmask of optional stats which are available
686b21b5f6ca2f Rob Clark 2023-05-24 897 * @region: The memory region
686b21b5f6ca2f Rob Clark 2023-05-24 898 *
686b21b5f6ca2f Rob Clark 2023-05-24 899 */
686b21b5f6ca2f Rob Clark 2023-05-24 900 void drm_print_memory_stats(struct drm_printer *p,
686b21b5f6ca2f Rob Clark 2023-05-24 901 const struct drm_memory_stats *stats,
686b21b5f6ca2f Rob Clark 2023-05-24 902 enum drm_gem_object_status supported_status,
cccad8cb432637 Adrián Larumbe 2023-08-24 903 const char *region,
cccad8cb432637 Adrián Larumbe 2023-08-24 904 unsigned int unit)
686b21b5f6ca2f Rob Clark 2023-05-24 @905 {
cccad8cb432637 Adrián Larumbe 2023-08-24 906 print_size(p, "total", region, stats->private + stats->shared, unit);
cccad8cb432637 Adrián Larumbe 2023-08-24 907 print_size(p, "shared", region, stats->shared, unit);
cccad8cb432637 Adrián Larumbe 2023-08-24 908 print_size(p, "active", region, stats->active, unit);
686b21b5f6ca2f Rob Clark 2023-05-24 909
686b21b5f6ca2f Rob Clark 2023-05-24 910 if (supported_status & DRM_GEM_OBJECT_RESIDENT)
cccad8cb432637 Adrián Larumbe 2023-08-24 911 print_size(p, "resident", region, stats->resident, unit);
686b21b5f6ca2f Rob Clark 2023-05-24 912
686b21b5f6ca2f Rob Clark 2023-05-24 913 if (supported_status & DRM_GEM_OBJECT_PURGEABLE)
cccad8cb432637 Adrián Larumbe 2023-08-24 914 print_size(p, "purgeable", region, stats->purgeable, unit);
686b21b5f6ca2f Rob Clark 2023-05-24 915 }
686b21b5f6ca2f Rob Clark 2023-05-24 916 EXPORT_SYMBOL(drm_print_memory_stats);
686b21b5f6ca2f Rob Clark 2023-05-24 917
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki