Re: [PATCH] dmaengine: fsl-edma: Remove unnecessary print function dev_err()

From: Frank Li
Date: Wed Aug 23 2023 - 23:14:30 EST


On Thu, Aug 24, 2023 at 10:34:17AM +0800, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> ./drivers/dma/fsl-edma-main.c:234:3-10: line 234 is redundant because platform_get_irq() already prints an error.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6208
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

> drivers/dma/fsl-edma-main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 63d48d046f04..d493dddd55b1 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -230,10 +230,8 @@ static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engi
>
> /* request channel irq */
> fsl_chan->txirq = platform_get_irq(pdev, i);
> - if (fsl_chan->txirq < 0) {
> - dev_err(&pdev->dev, "Can't get chan %d's irq.\n", i);
> + if (fsl_chan->txirq < 0)
> return -EINVAL;
> - }
>
> ret = devm_request_irq(&pdev->dev, fsl_chan->txirq,
> fsl_edma3_tx_handler, IRQF_SHARED,
> --
> 2.20.1.7.g153144c
>