seqlock:do_raw_write_seqcount_end smp_wmb

From: Kassey Li
Date: Wed Aug 23 2023 - 21:09:10 EST


hi, Peter:
I not quit sure on this, but is that a type error in do_raw_write_seqcount_end here ?
is this change necessary to match with do_raw_write_seqcount_begin ?


diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index 987a59d977c5..eb8807ed3a00 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -486,8 +486,8 @@ do { \

static inline void do_raw_write_seqcount_end(seqcount_t *s)
{
- smp_wmb();
s->sequence++;
+ smp_wmb();
kcsan_nestable_atomic_end();
}


to match with

static inline void do_raw_write_seqcount_begin(seqcount_t *s)
{
kcsan_nestable_atomic_begin();
s->sequence++;
smp_wmb();
}



BR
TNT