Re: [RFC PATCH 1/1] soc: qcom: Add driver to read secondary bootloader (XBL) log

From: Trilok Soni
Date: Wed Aug 23 2023 - 15:33:02 EST


On 8/23/2023 4:16 AM, Ninad Naik wrote:
  ret = map_addr_range(&parent, "uefi-log", xbl_data);

Here you are calling it as uefi-log. Is it xbl-log or uefi-log? Please decide first.


The reason for using "uefi-log" here is because this node name is in accordance to the sa8775p.dtsi as seen in [2]

[2] https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/sa8775p.dtsi#L354

So, in the next revision while adding the device tree bindings and corresponding compatible string, should this node name be changed as well?

Yes, please keep it consistent.

--
---Trilok Soni