RE: [PATCH net-next v6 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code

From: Justin Lai
Date: Wed Aug 23 2023 - 10:26:22 EST


> > +static int rtase_set_pauseparam(struct net_device *dev, struct
> > +ethtool_pauseparam *pause) {
> > + const struct rtase_private *tp = netdev_priv(dev);
> > + u16 value = RTL_R16(tp, CPLUS_CMD);
> > +
> > + value &= ~(FORCE_TXFLOW_EN | FORCE_RXFLOW_EN);
> > +
> > + if (pause->tx_pause)
> > + value |= FORCE_TXFLOW_EN;
> > +
> > + if (pause->rx_pause)
> > + value |= FORCE_RXFLOW_EN;
> > +
> > + RTL_W16(tp, CPLUS_CMD, value);
> > + return 0;
> > +}
>
> I'm pretty sure i said if pause->autoneg is true, you should return
> -EOPNOTUSPP.
>
> Andrew

Sorry this part has not been changed, I will modify this part in the next version.