Re: [PATCH net-next] net: dsa: use capital "OR" for multiple licenses in SPDX

From: Krzysztof Kozlowski
Date: Wed Aug 23 2023 - 05:48:55 EST


On 23/08/2023 11:32, Kurt Kanzenbach wrote:
> On Wed Aug 23 2023, Krzysztof Kozlowski wrote:
>> Documentation/process/license-rules.rst and checkpatch expect the SPDX
>> identifier syntax for multiple licenses to use capital "OR". Correct it
>> to keep consistent format and avoid copy-paste issues.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Reviewed-by: Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>
>
> Side note: The SPDX spec in section D.2 says: "License expression
> operators (AND, OR and WITH) should be matched in a case-sensitive
> manner.". Should is not must. So I assume checkpatch and spdxcheck
> should handle both cases. Especially because:
>
> |linux (git)-[master] % git grep 'SPDX' | grep ' or ' | wc -l
> |370
>

But "should" denotes preferred rule:

git grep "SPDX-Li" | grep " OR " | wc -l
7661

Best regards,
Krzysztof