Re: Re: [PATCH -next] scsi: core: fix double free in raid_component_add()

From: kernel test robot
Date: Tue Aug 22 2023 - 19:53:55 EST


Hi Bart,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mkp-scsi/for-next]
[cannot apply to next-20230821 jejb-scsi/for-next linus/master v6.5-rc7 next-20230822]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Bart-Van-Assche/Re-PATCH-next-scsi-core-fix-double-free-in-raid_component_add/20230822-035432
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/baecaad7-7124-b9ae-ab79-1b7c6fa95c98%40acm.org
patch subject: Re: [PATCH -next] scsi: core: fix double free in raid_component_add()
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230823/202308230741.jbMc6KYG-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230823/202308230741.jbMc6KYG-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308230741.jbMc6KYG-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/scsi/raid_class.c:212:13: warning: 'raid_component_release' defined but not used [-Wunused-function]
212 | static void raid_component_release(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~


vim +/raid_component_release +212 drivers/scsi/raid_class.c

b1081ea6f000de James Bottomley 2005-11-06 211
ee959b00c335d7 Tony Jones 2008-02-22 @212 static void raid_component_release(struct device *dev)
b1081ea6f000de James Bottomley 2005-11-06 213 {
ee959b00c335d7 Tony Jones 2008-02-22 214 struct raid_component *rc =
ee959b00c335d7 Tony Jones 2008-02-22 215 container_of(dev, struct raid_component, dev);
ee959b00c335d7 Tony Jones 2008-02-22 216 dev_printk(KERN_ERR, rc->dev.parent, "COMPONENT RELEASE\n");
ee959b00c335d7 Tony Jones 2008-02-22 217 put_device(rc->dev.parent);
b1081ea6f000de James Bottomley 2005-11-06 218 kfree(rc);
b1081ea6f000de James Bottomley 2005-11-06 219 }
61a7afa2c476a3 James Bottomley 2005-08-16 220

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki