Re: [PATCH v4 3/4] OPP: Add api to retrieve opps which is at most the provided level

From: kernel test robot
Date: Tue Aug 22 2023 - 19:11:09 EST


Hi Krishna,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/for-linus]
[also build test WARNING on robh/for-next rafael-pm/linux-next linus/master v6.5-rc7 next-20230822]
[cannot apply to pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Krishna-chaitanya-chundru/dt-bindings-pci-qcom-Add-opp-table/20230822-232104
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git for-linus
patch link: https://lore.kernel.org/r/1692717141-32743-4-git-send-email-quic_krichai%40quicinc.com
patch subject: [PATCH v4 3/4] OPP: Add api to retrieve opps which is at most the provided level
config: x86_64-randconfig-073-20230823 (https://download.01.org/0day-ci/archive/20230823/202308230637.gz3wmjrT-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230823/202308230637.gz3wmjrT-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308230637.gz3wmjrT-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/opp/core.c:756: warning: Function parameter or member 'level' not described in 'dev_pm_opp_find_level_floor'
>> drivers/opp/core.c:756: warning: Excess function parameter 'freq' description in 'dev_pm_opp_find_level_floor'
drivers/opp/core.c:2025: warning: Function parameter or member 'opp_table' not described in '_opp_set_supported_hw'
drivers/opp/core.c:2025: warning: Excess function parameter 'dev' description in '_opp_set_supported_hw'
drivers/opp/core.c:2068: warning: Function parameter or member 'opp_table' not described in '_opp_set_prop_name'
drivers/opp/core.c:2068: warning: Excess function parameter 'dev' description in '_opp_set_prop_name'
drivers/opp/core.c:2109: warning: Function parameter or member 'opp_table' not described in '_opp_set_regulators'
drivers/opp/core.c:2109: warning: Excess function parameter 'count' description in '_opp_set_regulators'
drivers/opp/core.c:2213: warning: Function parameter or member 'opp_table' not described in '_opp_set_clknames'
drivers/opp/core.c:2213: warning: Function parameter or member 'config_clks' not described in '_opp_set_clknames'
drivers/opp/core.c:2311: warning: Function parameter or member 'opp_table' not described in '_opp_set_config_regulators_helper'
drivers/opp/core.c:2375: warning: Function parameter or member 'opp_table' not described in '_opp_attach_genpd'
drivers/opp/core.c:2602: warning: Function parameter or member 'token' not described in 'dev_pm_opp_clear_config'
drivers/opp/core.c:2602: warning: Excess function parameter 'opp_table' description in 'dev_pm_opp_clear_config'


vim +756 drivers/opp/core.c

734
735
736 /**
737 * dev_pm_opp_find_level_floor() - Search for a rounded floor freq
738 * @dev: device for which we do this operation
739 * @freq: Start level
740 *
741 * Search for the matching floor *available* OPP from a starting level
742 * for a device.
743 *
744 * Return: matching *opp and refreshes *level accordingly, else returns
745 * ERR_PTR in case of error and should be handled using IS_ERR. Error return
746 * values can be:
747 * EINVAL: for bad pointer
748 * ERANGE: no match found for search
749 * ENODEV: if device not found in list of registered devices
750 *
751 * The callers are required to call dev_pm_opp_put() for the returned OPP after
752 * use.
753 */
754 struct dev_pm_opp *dev_pm_opp_find_level_floor(struct device *dev,
755 unsigned long *level)
> 756 {
757 return _find_key_floor(dev, level, 0, true, _read_level, NULL);
758 }
759 EXPORT_SYMBOL_GPL(dev_pm_opp_find_level_floor);
760

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki