Re: [PATCH] modpost: Skip .llvm.call-graph-profile section check

[Denis Nikitin]

Thanks for the prompt review!

On Tue, Aug 22, 2023 at 12:06 AM Fangrui Song <maskray@xxxxxxxxxx> wrote:
>
> On Mon, Aug 21, 2023 at 11:54 PM Denis Nikitin <denik@xxxxxxxxxxxx> wrote:
> >
> > .llvm.call-graph-profile section is added when the kernel is built with
> > profiles (e.g. -fprofile-sample-use=<llvm.profile>).
>
> Right. .llvm.call-graph-profile may also be added when the kernel is
> built with clang -fprofile-use= (though instrumentation-based PGO
> support is not upstreamed yet).

OK, I will add -fprofile-use.

> > The section holds
> > metadata for symbols beloning to other sections and hence doesn't need
> > modpost checks.
>
> Typo: belonging.
>
> .llvm.call-graph-profile contains edge information derived from text
> sections, so .llvm.call-graph-profile itself doesn't need more
> analysis as the text sections have been analyzed.

Ack.

Thanks,
Denis