Re: [Patch v4 3/4] RDMA/mana_ib : Create adapter and Add error eq

[Jason Gunthorpe]

On Tue, Aug 22, 2023 at 08:47:34AM -0700, sharmaajay@xxxxxxxxxxxxxxxxx wrote:

> +static void mana_ib_soc_event_handler(void *ctx, struct gdma_queue *queue,
> +				      struct gdma_event *event)
> +{
> +	struct mana_ib_dev *mib_dev = (struct mana_ib_dev *)ctx;
> +
> +	switch (event->type) {
> +	case GDMA_EQE_SOC_EVENT_NOTIFICATION:
> +		ibdev_dbg(&mib_dev->ib_dev, "Received SOC Notification");
> +		break;
> +	case GDMA_EQE_SOC_EVENT_TEST:
> +		ibdev_dbg(&mib_dev->ib_dev, "Received SoC Test");
> +		break;
> +	default:
> +		ibdev_dbg(&mib_dev->ib_dev, "Received unsolicited evt %d",
> +			  event->type);
> +	}
> +}

Did I miss something? What is the point of all this? Please don't add
test/dead code to the kernel. Come back when you have an actual use of
events on this channel.

Jason