Re: [PATCH v2] pinctrl: cherryview: fix address_space_handler() argument

From: Andy Shevchenko
Date: Tue Aug 22 2023 - 07:54:25 EST


On Tue, Aug 22, 2023 at 02:20:34PM +0300, Mika Westerberg wrote:
> On Tue, Aug 22, 2023 at 12:53:40PM +0530, Raag Jadav wrote:
> > First argument of acpi_*_address_space_handler() APIs is acpi_handle of
> > the device, which is incorrectly passed in driver ->remove() path here.
> > Fix it by passing the appropriate argument and while at it, make both
> > API calls consistent using ACPI_HANDLE().
> >
> > Fixes: a0b028597d59 ("pinctrl: cherryview: Add support for GMMR GPIO opregion")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Raag Jadav <raag.jadav@xxxxxxxxx>
>
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Pushed to my review and testing queue, thanks!

--
With Best Regards,
Andy Shevchenko