Re: [EXTERNAL] Re: [PATCH v2 2/5] dt-bindings: net: Add iep property in ICSSG dt binding

[Md Danish Anwar]

Hi Rob,

On 21/08/23 9:31 pm, Rob Herring wrote:
> On Mon, Aug 07, 2023 at 04:30:45PM +0530, MD Danish Anwar wrote:
>> Add iep node in ICSSG driver dt binding document.
> 
> Why?
> 
> Bindings are for h/w, not drivers. You are adding a property, not a 

I will change the above to "Add IEP property in ICSSG hardware DT binding
document."

> node. Would be nice to know what 'iep' is without having to look at the 
> diff (e.g. when running 'git log').
> 

Sure, I will provide description of IEP in the commit message.

>>
>> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx>
>> ---
>>  Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> index 8ec30b3eb760..36870238f92f 100644
>> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> @@ -52,6 +52,12 @@ properties:
>>      description:
>>        phandle to MII_RT module's syscon regmap
>>  
>> +  ti,iep:
>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> 
> phandle-array really means matrix, so you need to fully describe the 
> items constraints.
> 
>> +    maxItems: 2
> 
> 2 phandles or 1 phandle and 1 arg? Looks like the former from the 

It's 2 phandles.

> example, so:
> 
> maxItems: 2
> items:
>   maxItems: 1
> 

Sure, I will change the item constraints to above.

>> +    description:
>> +      phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver
>> +
>>    interrupts:
>>      maxItems: 2
>>      description:
>> @@ -155,6 +161,7 @@ examples:
>>                      "tx1-0", "tx1-1", "tx1-2", "tx1-3",
>>                      "rx0", "rx1";
>>          ti,mii-g-rt = <&icssg2_mii_g_rt>;
>> +        ti,iep = <&icssg2_iep0>, <&icssg2_iep1>;
>>          interrupt-parent = <&icssg2_intc>;
>>          interrupts = <24 0 2>, <25 1 3>;
>>          interrupt-names = "tx_ts0", "tx_ts1";
>> -- 
>> 2.34.1
>>

-- 
Thanks and Regards,
Danish.