Re: [PATCH v5 00/24] x86/resctrl: monitored closid+rmid together, separate arch/fs locking

From: Peter Newman
Date: Tue Aug 22 2023 - 04:42:38 EST


Hi James,

On Fri, Jul 28, 2023 at 6:43 PM James Morse <james.morse@xxxxxxx> wrote:
> James Morse (24):
> x86/resctrl: Track the closid with the rmid
> x86/resctrl: Access per-rmid structures by index
> x86/resctrl: Create helper for RMID allocation and mondata dir
> creation
> x86/resctrl: Move rmid allocation out of mkdir_rdt_prepare()
> x86/resctrl: Allow RMID allocation to be scoped by CLOSID
> x86/resctrl: Track the number of dirty RMID a CLOSID has
> x86/resctrl: Use set_bit()/clear_bit() instead of open coding
> x86/resctrl: Allocate the cleanest CLOSID by searching
> closid_num_dirty_rmid
> x86/resctrl: Move CLOSID/RMID matching and setting to use helpers
> tick/nohz: Move tick_nohz_full_mask declaration outside the #ifdef
> x86/resctrl: Add cpumask_any_housekeeping() for limbo/overflow
> x86/resctrl: Make resctrl_arch_rmid_read() retry when it is
> interrupted
> x86/resctrl: Queue mon_event_read() instead of sending an IPI
> x86/resctrl: Allow resctrl_arch_rmid_read() to sleep
> x86/resctrl: Allow arch to allocate memory needed in
> resctrl_arch_rmid_read()
> x86/resctrl: Make resctrl_mounted checks explicit
> x86/resctrl: Move alloc/mon static keys into helpers
> x86/resctrl: Make rdt_enable_key the arch's decision to switch
> x86/resctrl: Add helpers for system wide mon/alloc capable
> x86/resctrl: Add cpu online callback for resctrl work
> x86/resctrl: Allow overflow/limbo handlers to be scheduled on any-but
> cpu
> x86/resctrl: Add cpu offline callback for resctrl work
> x86/resctrl: Move domain helper migration into resctrl_offline_cpu()
> x86/resctrl: Separate arch and fs resctrl locks
>
> arch/x86/include/asm/resctrl.h | 90 +++++
> arch/x86/kernel/cpu/resctrl/core.c | 78 ++--
> arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 45 ++-
> arch/x86/kernel/cpu/resctrl/internal.h | 82 +++-
> arch/x86/kernel/cpu/resctrl/monitor.c | 440 ++++++++++++++++------
> arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 15 +-
> arch/x86/kernel/cpu/resctrl/rdtgroup.c | 340 ++++++++++++-----
> include/linux/resctrl.h | 43 ++-
> include/linux/tick.h | 9 +-
> 9 files changed, 870 insertions(+), 272 deletions(-)

I ran this series successfully against our internal test suites on the
following processors:

- Intel(R) Xeon(R) Platinum 8173M CPU @ 2.00GHz
- AMD EPYC 7B12 64-Core Processor

Tested-By: Peter Newman <peternewman@xxxxxxxxxx>

Thanks!
-Peter